Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update index.js #46

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Update index.js #46

merged 1 commit into from
Dec 20, 2018

Conversation

oliviertassinari
Copy link
Contributor

Any reason for creating a secrets for each request?

@dougwilson dougwilson added the pr label Dec 19, 2018
@dougwilson
Copy link
Contributor

Awesome, thanks @oliviertassinari ! There is no reason for it being there vs where you placed it. Your placement is better.

@dougwilson dougwilson self-assigned this Dec 20, 2018
@dougwilson dougwilson merged commit 677ed08 into expressjs:master Dec 20, 2018
dougwilson pushed a commit that referenced this pull request Dec 20, 2018
@oliviertassinari @dougwilson
perf: normalize secret argument only once
7ea8ab3 
closes #46
@oliviertassinari oliviertassinari deleted the patch-1 branch December 20, 2018 07:26
@oliviertassinari
Copy link
Contributor Author

Great, I only needed to access the cookie at some places, I ended up using cookie directly.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@dougwilson dougwilson

Labels
pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @dougwilson