Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

5.x: Upgrading merge-descriptors with allowing minors #5782

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

RobinTail
Copy link
Contributor

Similar to #5781 but for v5, with allowing minors according to the following request:
#5781 (comment)

@IamLizu
Copy link
Member

IamLizu commented Aug 23, 2024

Hi @RobinTail 👋

I hope you are doing fine. I am requesting you to move it v2. The idea is to upgrade all the dependencies first and then make node 18 as the minimum supported for express 5.

@RobinTail
Copy link
Contributor Author

RobinTail commented Aug 23, 2024

done, @IamLizu && @wesleytodd

Copy link
Member

@IamLizu IamLizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

A minor thing, could you please add this in the unreleased section in History file?

Edit: just letting you know that deps should be in alphabetical order.

@RobinTail
Copy link
Contributor Author

A minor thing, could you please add this in the unreleased section in History file?

done, @IamLizu

Copy link
Member

@IamLizu IamLizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants