Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build(deps): use carat notation for dependency versions #6317

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Feb 3, 2025

This updates semver ranges to use carat notation for a number of dependencies, towards the goals in #6316. @wesleytodd I know you said that issue isn't necessary complete - so if I jumped the gun, I can make whatever updates are needed 🙂 I also used that issue as a source of truth for which dependencies should be updated - there are still some without carat notation that I can also update if desired.

@bjohansebas
Copy link
Member

@dpopp07 can you fetch the latest changes from the repository? It's confusing to see that some dependencies aren't updating with this policy, but that's because they actually no longer exist.

@dpopp07
Copy link
Contributor Author

dpopp07 commented Feb 3, 2025

Ah, yes - will do. I built this off of the 5.x branch - should I have used a different base?

@bjohansebas
Copy link
Member

It should be master in this case

Signed-off-by: Dustin Popp <dustinpopp@ibm.com>
@dpopp07 dpopp07 changed the base branch from 5.x to master February 3, 2025 23:49
@dpopp07
Copy link
Contributor Author

dpopp07 commented Feb 3, 2025

Ah, my mistake! That makes more sense. The PR is updated 👍

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dpopp07

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I was planning to work on similar PR. Thanks @dpopp07 ❤️

@UlisesGascon
Copy link
Member

@wesleytodd can we include it in the next v5 release?

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Yes this needs to land before we do the next release. Should be good to land now I think.

@wesleytodd wesleytodd merged commit af7cd90 into expressjs:master Feb 5, 2025
21 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants