docs: add v5 migration note for app.listen #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
heidemn-faro
reviewed
Dec 4, 2024
carlosstenzel
approved these changes
Dec 4, 2024
dpopp07
force-pushed
the
dp/app-listen-change-v5
branch
from
ae63d87 to
40e9db5
Compare
Adds a note to the `migrating-5` guide alerting users that error events received by a server will now cause the callback argument in `app.listen` to be invoked. In Express 4, this was not the case and errors would be thrown. Resolves expressjs/express#6191 Signed-off-by: Dustin Popp <dustinpopp@ibm.com> Co-authored-by: M. Heide <66078329+heidemn-faro@users.noreply.github.com>
dpopp07
force-pushed
the
dp/app-listen-change-v5
branch
from
40e9db5 to
a042fc7
Compare
|
@bjohansebas @carlosstenzel thanks for reviewing! I cleaned up the linter errors. Is there anything I can do to fix the "Check Translation" build step failure? |
|
Hi @dpopp07, don't worry about the Check Translation workflow, it will always fail for PRs coming from a fork. I think this workflow should be removed |
github-actions
bot
added
requires-translation-fr
requires-translation-es
requires-translation-it
requires-translation-ja
requires-translation-ko
requires-translation-pt-br
requires-translation-ru
requires-translation-sk
requires-translation-th
requires-translation-tr
requires-translation-uk
requires-translation-uz
requires-translation-zh-cn
requires-translation-zh-tw
requires-translation-id
labels
|
@bjohansebas Great - I thought that might be the case but wanted to confirm you didn't need anything else from me. Thanks! |
UlisesGascon
approved these changes
Dec 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a note to the
migrating-5guide alerting users that error events received by a server will now cause the callback argument inapp.listento be invoked. In Express 4, this was not the case and errors would be thrown.Resolves expressjs/express#6191
Any feedback, rewording, etc. is welcome!