Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Check data and dataFrom for Vault provider path #6

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

rnrsr
Copy link
Contributor

@rnrsr rnrsr commented Aug 1, 2022

The data array can be empty if there is dataFrom instead. Use both to check for the Vault provider "path"

Each KES data or dataFrom spec must come from the same path prefix or it will error.

Signed-off-by: rnrsr <richard.nurser@gmail.com>
Copy link
Member

@moolen moolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution! Sorry for the late response, this PR somehow slipped through 😞

@moolen moolen merged commit cf4057b into external-secrets:main Sep 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants