Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for activerecord 8.0, ruby 3.4 (#35) #38

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

jmpage
Copy link
Contributor

@jmpage jmpage commented Feb 3, 2025

What did we change?

  • Bump dependency requirements so that this gem is compatible with ActiveRecord 8.0
  • Test against ActiveRecord 8.0
  • Test against Ruby 3.4

Why are we doing this?

Resolves #37 so that people who are using rails 8.0 can also use this gem.

How was it tested?

  • Specs
  • Locally
  • Staging

@jmpage jmpage force-pushed the jmp/support-activerecord-to-8.0 branch 4 times, most recently from 98ac240 to c5ebb64 Compare February 3, 2025 12:31
…el::Logger

rails/rails#54260 concurrent-ruby 1.3.5 introduces a change which
reveals a bug in activerecord 6.1 and 7.0, breaking specs
@jmpage jmpage force-pushed the jmp/support-activerecord-to-8.0 branch from c5ebb64 to 3e61e22 Compare February 3, 2025 12:35
@jmpage jmpage marked this pull request as ready for review February 3, 2025 12:38
@jmpage jmpage requested a review from a team as a code owner February 3, 2025 12:38
@jmpage jmpage merged commit a3919fb into main Feb 3, 2025
22 checks passed
@jmpage jmpage deleted the jmp/support-activerecord-to-8.0 branch February 3, 2025 14:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add support for Rails 8.0
2 participants