This repository has been archived by the owner on May 3, 2022. It is now read-only.
EZP-26145: Unable to undo in the RichText editor #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpobel Would it be possible to backport it to 1.3 series? Project that requires this fix does not run on 1.4 series yet. |
|
@lserwatka of course, but it would be easier if the affect version in the JIRA issue was right in the first place. |
|
+1 |
2 similar comments
|
+1 |
|
+1 |
This was referenced Aug 29, 2016
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-26145
Description
In Online Editor, some operations can not be undone, especially the removal of some text in the middle of a paragraph. This is happening because while doing that, we are also cleaning up some auto-generated ids and this seems to confuse the undo manager. To avoid that, before cleaning up the ids, the undo manager is locked so that the cleanup is not part of the undo stack.
Tests
manual tests + unit tests