This repository has been archived by the owner on May 3, 2022. It is now read-only.
EZP-25002: Added buttons to add/remove options in Selection settings #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2016
StephaneDiot
approved these changes
Nov 29, 2016
yannickroger
approved these changes
Nov 30, 2016
dpobel
force-pushed
the
ezp-25002_add_remove_options_selection
branch
from
422a0e3 to
9742d8a
Compare
|
@yannickroger @StephaneDiot QA found an issue when you remove an option in the middle of the list, apply, add an option and then apply again. To avoid that, I added 2ffa7ad (and ezsystems/repository-forms@e62f9c3 in the repository-forms pull request) so that options are reindexed after each removal/addition so that we don't loose any option. |
|
You should rebase on top of master to avoid the PHP 5.5 travis failure. |
|
@bdunogier it's for 1.6 :) |
|
still +1 |
dpobel
force-pushed
the
ezp-25002_add_remove_options_selection
branch
from
2ffa7ad to
b534936
Compare
dpobel
force-pushed
the
ezp-25002_add_remove_options_selection
branch
from
b534936 to
fcb786c
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-25002
Requires ezsystems/repository-forms#99
Description
This PR (with the one on repository-forms) adds a UI to add or remove options in Selection field definitions. This is done in a way that also allows to do it only with the keyboard.
(Correct terms in the button will be added later in ezsystems/repository-forms#99 once the translation system is stabilized)
Screencast:
Tests
manual tests + unit tests