This repository has been archived by the owner on May 3, 2022. It is now read-only.
Fix EZP-26515: Unable to select an old draft to edit if there are too many #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpobel
reviewed
Dec 1, 2016
| @@ -4,6 +4,11 @@ | |||
| */ | |||
|
|
|||
|
|
|||
| .ez-view-draftconflictview { | |||
| overflow: auto; | |||
| max-height: 30em; | |||
There was a problem hiding this comment.
30em ? what is the reasoning behind this value ?
yannickroger
force-pushed
the
ezp-26515-draft_list_scroll_16
branch
from
99ebb10 to
25d78b0
Compare
|
@dpobel The solution you gave works fine. PR updated. |
dpobel
approved these changes
Dec 2, 2016
StephaneDiot
approved these changes
Dec 6, 2016
yannickroger
force-pushed
the
ezp-26515-draft_list_scroll_16
branch
from
25d78b0 to
43d2005
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: https://jira.ez.no/browse/EZP-26515
Description
When to many draft are present, the bottom of the list is hidden bellow the screen limit. This patch adds a scrollbar when the list is too long.
Tests
Manual tests on firefox and chrome