This repository has been archived by the owner on May 3, 2022. It is now read-only.
Fix EZP-26768 : YUI3 from external Yahoo CDNs #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When combine: false is set in yui.yml file it tries to download YUI3 from external Yahoo CDNs. This is broken on HTTPS Even if combine option is false, YUI use the combo loading for it's own files
nicolas-bastien
requested review from
bdunogier,
andrerom,
StephaneDiot and
sunpietro
andrerom
approved these changes
Dec 12, 2016
|
@andrerom yes it won't use yahoo cdn anymore. |
|
ok, well we might be missing the people that could give insight if that is supposed to be supported somehow atm. |
|
Hard to say from my perspective. I wouldn't merge this without @dpobel's review. |
dpobel
approved these changes
Jan 2, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.ez.no/browse/EZP-26768
Description
When combine: false is set in yui.yml file it tries to download YUI3 from external Yahoo CDNs.
This is broken on HTTPS.
More details
Even if combine option is false, YUI uses the combo loading for it's own files. If comboBase and root are not set, YUI will load from http://yui.yahooapis.com with an hard coded 'http'.
Setting this options allows to load YUI internal files from ezcombo every project files are loaded separately.
Test manually
plateform-ui-bundle/Resources/config/yui.yml.-> the dashboard or login screen should appear normally
(Before this fix it's blocked on loading with JS errors)
QA