This repository has been archived by the owner on May 3, 2022. It is now read-only.
EZP-26736: Allow users to define the "title" attribute on links on the rich text editor #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpobel
force-pushed
the
ezp-26736_link_title
branch
from
cbe157a to
3eb292f
Compare
StephaneDiot
approved these changes
Jan 18, 2017
…lt one For now, this custom "button" (it's more a modal window), displays differently the link properties and allows to define a title on link. One next step is to support internal link.
dpobel
force-pushed
the
ezp-26736_link_title
branch
from
3eb292f to
370b9e6
Compare
yannickroger
approved these changes
Jan 19, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-26736
Description
This patch brings the ability for the user to set a title on links in the RichText editor. To do that, we are forced to override the default
linkEditbutton to slightly change how link properties are displayed/editable.Screencast:
Tests
unit tests + manual tests