This repository has been archived by the owner on May 3, 2022. It is now read-only.
EZP-26734: Accordion on main titles of ContentTypeView #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickroger
changed the title
yannickroger
force-pushed
the
ezp-26734-accordion
branch
from
7e9497f to
d51af9a
Compare
yannickroger
changed the title
|
Ready for review @dpobel @StephaneDiot and others |
dpobel
suggested changes
Jan 25, 2017
| } | ||
|
|
||
| .ez-view-serversideview .ez-contenttype-view summary::after { | ||
| content: '\e605'; |
There was a problem hiding this comment.
missing indent (below as well)
| <div class="ez-contenttype-metadata-name">{{ "content_type.default_children_sorting"|trans|desc("Default property for sorting chilren") }}</div> | ||
| <div class="ez-contenttype-metadata-value"> | ||
| {{ ("content_type.sort_field." ~ content_type.defaultSortField)|trans(domain="ezrepoforms_content_type") }} / {{ ("content_type.sort_order." ~ content_type.defaultSortOrder)|trans(domain="ezrepoforms_content_type") }} | ||
| <details open="open"> |
There was a problem hiding this comment.
instead of adding details here, I would replace the previous section element by details (and the same should be possible for others details as far as I can tell)
| border-bottom: 1px solid #2b84b1; | ||
|
|
||
| /* Hide marker on Firefox */ | ||
| display: block; |
There was a problem hiding this comment.
that's kind of hack :) It seems in Firefox you can write:
list-style-type: none;
yannickroger
force-pushed
the
ezp-26734-accordion
branch
from
274a64a to
fe2e3be
Compare
|
Feedback taken into account @dpobel |
dpobel
previously approved these changes
Jan 25, 2017
dpobel
dismissed
their stale review
actually you also need re generate the translation file, there should be less changes now
StephaneDiot
approved these changes
Jan 26, 2017
yannickroger
force-pushed
the
ezp-26734-accordion
branch
from
fe2e3be to
2a66159
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: https://jira.ez.no/browse/EZP-26734
Description
Adds accordions on the main titles of the Content Type View and adds an
additional informationbutton to display the field's information.It will not work on IE/Edge for now because HTML5
details/summaryis not implemented yet.Screencast: https://drive.google.com/file/d/0B5amepf6EkXbejlUTFp5NnM4ZzA/view?usp=sharing
Another video about accordion: https://www.youtube.com/watch?v=cZFUNo9qOBE
Tests
Manual test on Firefox and Chrome
TODO