This repository has been archived by the owner on May 3, 2022. It is now read-only.
Replace deprecated templating.helper.assets with assets.packages service #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
approved these changes
Jan 27, 2017
|
Merging for testing with Sf 3.2, failure is ezrobot caused by upgrade of php-cs-fixer. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out there's more to AssetsHelper issue than just unit test. I expected that but couldn't find any relevant info until I tried to compile Symfony 3 container for eZ Platform 2.0.
The
@templating.helper.assetsservice has been deprecated and got removed in Symfony3.x. It needs to be replaced with@assets.packagesservice.TODO:
@templating.helper.assetsservice with@assets.packagesservice (31aef5a).%parameters%in Yaml as keeping them unquoted is deprecated since Symfony3.x(e702486). // small fix, so I included it in the scope of this PR