This repository has been archived by the owner on May 3, 2022. It is now read-only.
Fix EZP-26862 Content create with forced language #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @dpobel @yannickroger |
|
Where do the ezrobot code review results show? |
StephaneDiot
changed the title
StephaneDiot
changed the base branch from
1.7
to
EZP-26130_Search_for_content_with_many_locations_master
|
@DavidLiedle normally in a comment in the pull request, but it seems the upgrade done lastly by Vidar broke that. |
StephaneDiot
force-pushed
the
Fix/EZP-26862_Content_Edit_with_unknown_language
branch
from
5b29114 to
052aaa6
Compare
StephaneDiot
changed the base branch from
EZP-26130_Search_for_content_with_many_locations_master
to
1.7
dpobel
suggested changes
Jan 31, 2017
| @@ -196,12 +196,12 @@ YUI.add('ez-contenttypeselectorview', function (Y) { | |||
| * | |||
| * @event createContent | |||
| * @param {eZ.ContentType} contentType | |||
| * @param {String} languageCode (always set to "eng-GB"). This | |||
| * parameter is deprecated and will be removed in PlatformUI 2.0 | |||
| * @param {String} (Optional) languageCode If none provided the contentCreationDefaultLanguageCode of the app is used. | |||
There was a problem hiding this comment.
[languageCode] and the english description should be improved for human ;)
dpobel
reviewed
Jan 31, 2017
StephaneDiot
force-pushed
the
Fix/EZP-26862_Content_Edit_with_unknown_language
branch
from
914379d to
5eab2ac
Compare
|
updated @dpobel |
|
👍 :) |
dpobel
suggested changes
Jan 31, 2017
| @@ -196,12 +196,12 @@ YUI.add('ez-contenttypeselectorview', function (Y) { | |||
| * | |||
| * @event createContent | |||
| * @param {eZ.ContentType} contentType | |||
| * @param {String} languageCode (always set to "eng-GB"). This | |||
| * parameter is deprecated and will be removed in PlatformUI 2.0 | |||
| * @param {String} (Optional) [languageCode] If none provided the content creation default language of the app is used. | |||
There was a problem hiding this comment.
you can remove (Optional) if you put the parameter between [ and ]
StephaneDiot
force-pushed
the
Fix/EZP-26862_Content_Edit_with_unknown_language
branch
from
5eab2ac to
09d3898
Compare
|
updated @dpobel @yannickroger |
dpobel
approved these changes
Jan 31, 2017
yannickroger
approved these changes
Jan 31, 2017
StephaneDiot
deleted the
Fix/EZP-26862_Content_Edit_with_unknown_language
branch
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira: https://jira.ez.no/browse/EZP-26862
Description
PlatformUI was always creating content with the default create language of the app. Now we can set a languageCode to the createContent event to force a content creation on a given language.
Tests
Manually and unit tested