This repository has been archived by the owner on May 3, 2022. It is now read-only.
EZP-26899: Handle internal links when displaying RichText fields #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickroger
approved these changes
Feb 3, 2017
dpobel
force-pushed
the
ezp-26899_internal_link_browsing
branch
from
07d2b25 to
656c8b5
Compare
dew326
reviewed
Feb 3, 2017
| attrs = {'loadingError': false}; | ||
| attrs = {'loadingError': false}, | ||
| callback = function (error, result, resultCount) { | ||
| attrs.loadingError = error ? true : false; |
There was a problem hiding this comment.
What do you think about writing it like this: attrs.loadingError = !!error;?
There was a problem hiding this comment.
hum it's more a matter of taste than anything but the ternary version is maybe a tiny bit more readable :)
StephaneDiot
approved these changes
Feb 3, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-26899
Description
This patch makes sure internal links (
ezlocation://) links are usable in PlatformUI. If an internal link points to a removed Location or a Location the user is not able to see, the link is just disabled.Screencast:
Tests
unit test + manual tests