[Behat] EZP-26945: Update sentence related to handling the UDW #802
Conversation
|
ping @bdunogier @pcardiga and thank you @damianz5 for help |
micszo
force-pushed
the
ezp-26945-update-udw-handling
branch
from
5fc17e3 to
090ad66
Compare
|
|
Perfect. I'll have looks. |
| @@ -286,6 +286,18 @@ public function selectFromUniversalDiscovery($path) | |||
| } | |||
|
|
|||
| /** | |||
| * @When I select the :path folder in the new Universal Discovery Widget | |||
There was a problem hiding this comment.
It's not for you to fix, @micszo, but we need to name this thing. Nobody loves being called "the new XXX" :)
There was somthing about "Finder" but a) it might be copyrighted b) it includes explorer (the pane based thing), search and on-the-fly content creation, so it's probably not a good name.
There was a problem hiding this comment.
"the new XXXX" is a bad idea, at some point there will be a new new XXXX ;-)
joke aside, "in the Finder method of Universal Discovery Widget" would a good way to describe that operation.
|
Actually, thinking about it... does the "old" widget still work ? Are the elements for its implementation still there ? If they're not, how can some parts of the application use the old one ? |
|
I meant this place (on 1.8.0-beta1): |
micszo
force-pushed
the
ezp-26945-update-udw-handling
branch
from
090ad66 to
37c295b
Compare
micszo
changed the title
|
ping @bdunogier @dpobel |
|
ah that clarifies it :) |
| @@ -15,7 +15,7 @@ Feature: Copy content | |||
| And a "News Flash" article exists | |||
| And I am on "News Flash" full view | |||
| When I click on the action bar button "Copy" | |||
| And I select the "eZ Platform/Destination" folder in the Universal Discovery Widget | |||
| And I select the "eZ Platform/Destination" folder in the Finder method of Universal Discovery Widget | |||
There was a problem hiding this comment.
Will it break if we just replace the existing sentence with this new implementation ? We don't really care how the method is selected, do we ? We just want to select something.
micszo
force-pushed
the
ezp-26945-update-udw-handling
branch
from
37c295b to
69ba9c4
Compare
|
ping @bdunogier, now simplified. :) |
micszo
changed the title
micszo
force-pushed
the
ezp-26945-update-udw-handling
branch
from
69ba9c4 to
5e7d64c
Compare
|
ping @bdunogier, @dpobel, @andrerom. It's ready. |
micszo
changed the title
micszo
force-pushed
the
ezp-26945-update-udw-handling
branch
from
5e7d64c to
d62f4bb
Compare
|
ping @bdunogier @dpobel |
|
Sorry, @micszo, too many topics at the same time :) I'll have a look asap. |
Features/Context/PlatformUI.php
Outdated
| * @param NodeElement $parentNode The base node to expand from, if null defaults to the content browser root | ||
| * @throws \Exception When not found | ||
| */ | ||
| protected function openBrowserNode($text, $parentNode) |
There was a problem hiding this comment.
What about openFinderExplorerNode ? Would it be closer from the actual role it has ?
Features/Context/PlatformUI.php
Outdated
| * @param string $path The content browser path such as 'Content1/Content2/ContentIWantToClick' | ||
| * @param NodeElement $node The base node to expand from | ||
| */ | ||
| public function openBrowserPath($path, $node) |
micszo
force-pushed
the
ezp-26945-update-udw-handling
branch
from
d62f4bb to
4a0bd17
Compare
|
ping @bdunogier, updated. |
|
@bdunogier is any other change needed? Are we good to go? From my pov it's ready. Please merge. |
|
As this is passing and purely about unblocking tests I'll merge this, thanks @micszo! |
Jira ticket: https://jira.ez.no/browse/EZP-26945
Added implementation of Behat methods for handling the finder explorer.