This repository has been archived by the owner on May 3, 2022. It is now read-only.
EZP-26872: Add support for starting Location id in the UDW Finder #804
+756
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpobel
force-pushed
the
ezp-26872_starting_location
branch
from
2938160 to
e0698c7
Compare
dpobel
commented
Feb 9, 2017
| @@ -22,6 +22,60 @@ YUI.add('ez-universaldiscoveryviewservice', function (Y) { | |||
| */ | |||
| Y.eZ.UniversalDiscoveryViewService = Y.Base.create('universalDiscoveryViewService', Y.eZ.ViewService, [Y.eZ.SideViewService], { | |||
| /** | |||
| * | |||
There was a problem hiding this comment.
@StephaneDiot : missing doc
| }, | ||
|
|
||
| /** | ||
| * `Get the path of the UDW starting Location. |
There was a problem hiding this comment.
@StephaneDiot : not Get (it returns nothing) but Loads
| * @method _loadStartingLocationPath | ||
| * @protected | ||
| * @param {eZ.Location} startingLocation | ||
| * @param {Function} callback |
There was a problem hiding this comment.
@StephaneDiot missing doc for the callback parameter
| ATTRS: { | ||
|
|
||
| /** | ||
| * Holds the starting location where the UDW will . |
There was a problem hiding this comment.
@StephaneDiot the end of the sentence is missing
| * | ||
| * @attribute startingLocation | ||
| * @default false | ||
| * @type {eZ.Location} |
There was a problem hiding this comment.
@StephaneDiot this should reflect the fact it can be false
dpobel
changed the title
StephaneDiot
approved these changes
Feb 9, 2017
yannickroger
approved these changes
Feb 10, 2017
| * @method _loadStartingLocationPath | ||
| * @protected | ||
| * @param {eZ.Location} startingLocation | ||
| * @param {Function} callback Executed after loading the path. Takes the location containing the path in parameter or false if loading error. |
There was a problem hiding this comment.
Nitpick: line too long
| this.wakeUp(); | ||
| } | ||
| }); | ||
| this.on('*:explorerNavigate', function(e) { | ||
| this._handleLevelViews(e.target, e.depth, e.location); | ||
| }); | ||
| this.after('startingLocationChange', function (e) { | ||
| if ( e.newVal === e.prevVal ) { | ||
| // this is to avoid rebuilding the level views when a |
There was a problem hiding this comment.
Missing capital letter. Lines are too short. Sentences are long and weird.
| @@ -138,11 +178,15 @@ YUI.add('ez-universaldiscoveryfinderexplorerview', function (Y) { | |||
| * | |||
| * @method _addLevel | |||
| * @param {Y.eZ.Location} location the parent location | |||
| * @param {Number} the location id that should be selected in the level | |||
There was a problem hiding this comment.
Name of the parameter is missing
| @@ -170,19 +214,33 @@ YUI.add('ez-universaldiscoveryfinderexplorerview', function (Y) { | |||
| }, | |||
|
|
|||
| /** | |||
| * The starting Location model if the UDW is configured with one. | |||
| @@ -150,20 +150,32 @@ YUI.add('ez-universaldiscoveryfinderview', function (Y) { | |||
| }, | |||
|
|
|||
| /** | |||
| * Holds the virtual root location | |||
| * The starting Location model if the UDW is configured with one. It | |||
There was a problem hiding this comment.
Same here. We usually call it Location without model
dpobel
force-pushed
the
ezp-26872_starting_location
branch
from
5c6915c to
b16570b
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-26872
replaces #799
Description
This patch brings the support of the starting Location id UDW parameter to the Finder method.
Screencast:
Tests
manual tests + unit tests