Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Fix EZP-26996: typo in translation for locationview.details.remoteid #805

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Fix EZP-26996: typo in translation for locationview.details.remoteid #805

merged 1 commit into from
Feb 16, 2017

Conversation

wizhippo
Copy link
Contributor

No description provided.

Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdunogier / @yannickroger Does this affect the i18n packages?

@dpobel dpobel changed the base branch from master to 1.7 February 15, 2017 15:14
@dpobel dpobel changed the base branch from 1.7 to master February 15, 2017 15:15
Copy link
Contributor

@dpobel dpobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course the change is ok :) but we should fix that first in 1.7 and then in 1.8 and master.
@wizhippo could you rebase your branch and change the base branch to 1.7 ?

@wizhippo wizhippo changed the base branch from master to 1.7 February 15, 2017 16:01
@wizhippo
Copy link
Contributor Author

@dpobel I believe I have done as you asked.

@bdunogier
Copy link
Member

@bdunogier / @yannickroger Does this affect the i18n packages?

Yes it does, starting from 1.8, using the new bin/extract-translations.sh.
The strings also need to be generated for 1.7, but the script is probably different.

@bdunogier
Copy link
Member

After talking to Damien, no need to run any script, since the english string only exists in translation files.

What will have to be done is execute bin/synchronize-translations.sh from ezplatform after the merge, and commit to ezsystems/ezplatform-i18n after the sync.

@dpobel
Copy link
Contributor

dpobel commented Feb 16, 2017

perfect @wizhippo , I'm merging and taking care of forward porting :) thanks again

@dpobel dpobel merged commit 55b8d0f into ezsystems:1.7 Feb 16, 2017
@wizhippo wizhippo deleted the patch-1 branch February 16, 2017 14:14
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants