This repository has been archived by the owner on May 3, 2022. It is now read-only.
Fix EZP-27147: Not translatable binary fields can be updated using drag&drop #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpobel
approved these changes
Mar 29, 2017
| @@ -357,6 +357,9 @@ YUI.add('ez-binarybase-editview', function (Y) { | |||
| */ | |||
| _prepareDrop: function (e) { | |||
| e.preventDefault(); | |||
| if (this.get('isNotTranslatable')) { | |||
There was a problem hiding this comment.
I would do this check before preventing the default behavior and not calling e.preventDefault() if drag and drop is not handled
There was a problem hiding this comment.
If I do that, the browsers reads the image as a file (instead of the page) file://myfile.png
There was a problem hiding this comment.
that's the default browser's behavior when you drop an image in a page that does not handle the drop event. And indeed, you are right, it makes sense to avoid it, so you can keep the code as it is.
| @@ -394,6 +397,10 @@ YUI.add('ez-binarybase-editview', function (Y) { | |||
| var files = e._event.dataTransfer.files; | |||
|
|
|||
| e.preventDefault(); | |||
| if (this.get('isNotTranslatable')) { | |||
StephaneDiot
approved these changes
Apr 3, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: https://jira.ez.no/browse/EZP-27147
Description
When fixing the fields in #788 I forgot to prevent from drag and dropping on binary fields. So goal of this PR is to fix that.
Tests
Manual test and completed unit tests