This repository has been archived by the owner on May 3, 2022. It is now read-only.
Fix EZP-27144: Current location not viewable when content browsing #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDiot
force-pushed
the
Fix-EZP-27144_Selecting_current_location_in_finder
branch
from
11b8614 to
2183d6b
Compare
dpobel
suggested changes
Apr 5, 2017
| @@ -60,6 +60,12 @@ YUI.add('ez-discoverybarviewservice', function (Y) { | |||
| startingLocationId: startingLocationId, | |||
| minDiscoverDepth: rootDepth, | |||
| confirmLabel: Y.eZ.trans('view.content.label', {}, 'bar'), | |||
| isSelectable: function(contentStruct) { | |||
| if (startingLocationId === contentStruct.location.get('id')) { | |||
There was a problem hiding this comment.
can be simplified (and cs issue, missing space after function):
isSelectable: function (contentStruct) {
return startingLocationId !== contentStruct.location.get('id');
}| Assert.isFunction(e.config.isSelectable, "config should have a function named isSelectable"); | ||
|
|
||
| Y.Assert.isTrue( | ||
| e.config.isSelectable({location: otherLocation}), |
There was a problem hiding this comment.
please add 2 new test cases that would call the isSelectable function and make sure the starting Location can not be selected and any other Location is selectable.
|
Updated ping @dpobel @yannickroger |
dpobel
approved these changes
Apr 10, 2017
| @@ -60,6 +60,9 @@ YUI.add('ez-discoverybarviewservice', function (Y) { | |||
| startingLocationId: startingLocationId, | |||
| minDiscoverDepth: rootDepth, | |||
| confirmLabel: Y.eZ.trans('view.content.label', {}, 'bar'), | |||
| isSelectable: function(contentStruct) { | |||
There was a problem hiding this comment.
space still missing after function ...
StephaneDiot
force-pushed
the
Fix-EZP-27144_Selecting_current_location_in_finder
branch
from
28aaace to
a80dbe3
Compare
yannickroger
approved these changes
Apr 10, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira : https://jira.ez.no/browse/EZP-27144
Description
When a user wanted to browse with the finder the current location where he currently was this was resulting in an infinite loading. Now the user can only select another location than the one he is on ( or cancel to stay on it obviously )
Screencast
https://youtu.be/w5M2Wfygc_8
Tests
Manually and unit tested