Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Fix EZP-27252: Wrong message when deleting trash content #846

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Apr 14, 2017

JIRA issue: https://jira.ez.no/browse/EZP-27252

Description

This PR fixes missing % for count parameter in source/target translation of items.permanently.deleted key in /Resources/translations/trash.en.xlf

Steps to reproduce:

  • On the admin interface, go to trash and click on "Empty the trash";
  • After trash is deleted, the following message is displayed at the bottom:
    %count items were permanently deleted.
    ...which does not reflect the number of contents deleted - see attached screenshot.

@yannickroger
Copy link
Contributor

You need to fix it in 1.7 (oldest supported branch), it is also happening there: https://github.com/ezsystems/PlatformUIBundle/blob/1.7/Resources/translations/trash.en.xlf#L52

@adamwojs adamwojs changed the base branch from 1.8 to 1.7 April 14, 2017 10:50
@adamwojs adamwojs force-pushed the Fix-EZP-27252_wrong_message_when_deleting_trash_content branch from 2d064b4 to 92cd696 Compare April 14, 2017 11:04
@yannickroger yannickroger merged commit cd587ae into ezsystems:1.7 Apr 18, 2017
@yannickroger
Copy link
Contributor

Thanks @adamwojs

@adamwojs
Copy link
Member Author

You welcome @yannickroger!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants