This repository has been archived by the owner on May 3, 2022. It is now read-only.
Fix EZP-27330: Full name in preview box and on hover of the link in UDW #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
approved these changes
Jun 2, 2017
|
+1 for the CSS changes of the PR but it's not corresponding to the description: this PR doesn't fixes the preview box so it can show the full name of selected content For that you need to apply the CSS changes that is in #863 on Resources/public/css/views/universaldiscovery/selected.css (removing |
dpobel
suggested changes
Jun 5, 2017
| font-weight: bold; | ||
| margin-top: 5px; |
There was a problem hiding this comment.
please no px, we use relative unit, em usually for margins
| } | ||
|
|
||
| .ez-view-universaldiscoveryselectedview .ez-ud-selected-infos .ez-ud-selected-info { | ||
| margin-bottom: 0.5em; | ||
| margin-left: 0; | ||
| font-size: 0.8em; |
There was a problem hiding this comment.
to not repeat that, what about defining the font-size on .ez-ud-selected-infos ?
|
@dpobel @StephaneDiot Thank you for review. I've applied suggested changes. |
dpobel
approved these changes
Jun 12, 2017
dpobel
suggested changes
Jun 12, 2017
dpobel
approved these changes
Jun 12, 2017
adamwojs
force-pushed
the
Fix-EZP-27330_full_name_in_preview_box_and_on_hover_of_the_link
branch
from
e48af14 to
69a05ce
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the preview box so it can show the full name of selected content. Based on CSS proposed by @inakijv in JIRA issue.
Screenshot
Related PRs