-
Notifications
You must be signed in to change notification settings - Fork 47
EZP-28030: Alloy editor add support for more builtin buttons #905
Conversation
* | ||
* @class eZ.AlloyEditor.ButtonList | ||
*/ | ||
ButtonList = React.createClass({displayName: "ButtonListIndexed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think something is wrong with this generated js. I think this should be ButtonListIndexed = ...
instead of ButtonList = ...
Fixed the wrongly generated js. @Plopix did you test this extensively btw? was the format properly saved to richtext and back to view and edit? @dew326 looks ok? If so we can potentially send to QA to make sure proper testing is done. |
@andrerom now it looks ok and I think we can send this to QA. |
Thanks @micszo, then we will probably keep this for 1.13 release, it needs a deeper look and work on kernel. |
@micszo Tested and only found issues with striked: ezsystems/ezpublish-kernel#2103 What browser did you use? |
I used Chrome. |
@andrerom it is in prod for on EE project. I tested the basics, store, edit, view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good: checked editing, viewing and modifying on multiple browsers (Chrome, Safari, Firefox). Tested briefly on Edge, needs broader testing during certification.
Thanks @mnocon ! Followups:
|
This PR adds
'subscript', 'superscript', 'quote', 'strike',
and'numbered list'
Enjoy
Todo: