This repository has been archived by the owner on May 3, 2022. It is now read-only.
EZP-28104: As a Editor I want empty Performance tab removed #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
force-pushed
the
remove_performance_tab
branch
2 times, most recently
from
0081602 to
464b0f8
Compare
As the planned feature for this tab won't happen before v2 it has been approved by PM to remove ths for 1.x. And for 2.x we won't add it before it actually has functionality.
andrerom
force-pushed
the
remove_performance_tab
branch
from
464b0f8 to
e1ada43
Compare
andrerom
changed the title
|
@sunpietro @dew326 could you please have a look here? |
sunpietro
suggested changes
Oct 19, 2017
| @@ -152,7 +148,7 @@ YUI.add('ez-navigationhubview-tests', function (Y) { | |||
| userProfileView: this.userProfileView, | |||
| container: '.container', | |||
| user: this.userMock, | |||
| studioplusNavigationItems: [ | |||
| studioNavigationItems: [ | |||
There was a problem hiding this comment.
I think, the whole property (and related tests) can be removed, unless you want to test any other tab - the studio tab in this case. Do you agree?
There was a problem hiding this comment.
removing it I think broke some of the tests, as some expects several zones, so hence the adaption here in the end result. I could adapt it, but then I would need to try to understand what the tests are trying to cover, which can be tricky in some cases as I don't know the intention.
dew326
approved these changes
Oct 19, 2017
sunpietro
approved these changes
Oct 19, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the planned feature for this tab won't happen before v2 it has been approved by PM (slack product channel, sept 14th) to remove this for 1.x. And for 2.x we won't add it before it actually has functionality.
Todo: