This repository has been archived by the owner on May 3, 2022. It is now read-only.
EZEE-1851: shell.html.twig should be rendered with language based on Accept-Language header value #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Accept-Language header value
kmadejski
approved these changes
Feb 2, 2018
andrerom
approved these changes
Feb 5, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Platform UI choose interface language based on
Accept-Languageheader value, but the translatable config values passed from backend to frontend via\EzSystems\PlatformUIBundle\ApplicationConfig\Provider, use language based on siteaccess.This inconsistency makes user unable to render the landing page block name and landing page block attribute names in the correct language.