This repository has been archived by the owner on May 3, 2022. It is now read-only.
EZP-29279: Fix value displayed by the Date Field Type being affected by browser time zone #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by browser time zone
sunpietro
suggested changes
Aug 16, 2018
| * @return String | ||
| */ | ||
| _formatDate: function (date) { | ||
| return date.toLocaleDateString( |
There was a problem hiding this comment.
It's better readable when it looks like this:return date.toLocaleDateString(undefined, {timeZone: 'UTC'});
| * @method _formatDate | ||
| * @protected | ||
| * @param {Date} date | ||
| * @return String |
…fected by browser time zone
|
@sunpietro fixed, thanks. |
dew326
approved these changes
Aug 16, 2018
sunpietro
approved these changes
Aug 16, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: EZP-29279
Currently the value for Date Field Type displayed in the backoffice is affected by the browser's timezone, meaning that if the browser has timezone below (west of) UTC, then the previous day is displayed.
Value stored in the database is always midnight in UTC.
Javascript automatically uses the browser's timezone when handling Date objects, so in this PR I fix the issue by manually adding the offset.