Merge pull request #1345 from ezsystems/EZP-31449

EZP-31449: Adapted TranslatablePropertyTransformer to properly handle nulls
ezsystems · Apr 17, 2020 · 7585a8e · 7585a8e
2 parents 37dde64 + 463f0c1
commit 7585a8e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/lib/Form/DataTransformer/TranslatablePropertyTransformer.php b/src/lib/Form/DataTransformer/TranslatablePropertyTransformer.php
@@ -36,9 +36,7 @@ public function transform($valueAsHash)
 
     public function reverseTransform($value)
     {
-        if (!$value) {
-            return null;
-        }
+        $value = (false === $value || [] === $value) ? null : $value;
 
         return [$this->languageCode => $value];
     }

diff --git a/src/lib/Tests/Form/DataTransformer/TranslatablePropertyTransformerTest.php b/src/lib/Tests/Form/DataTransformer/TranslatablePropertyTransformerTest.php
@@ -60,8 +60,8 @@ public function testReverseTransform($inputValue, $languageCode, $expected)
     public function reverseTransformProvider()
     {
         return [
-            [false, 'fre-FR', null],
-            [null, 'fre-FR', null],
+            [false, 'fre-FR', ['fre-FR' => null]],
+            [null, 'fre-FR', ['fre-FR' => null]],
             ['français', 'fre-FR', ['fre-FR' => 'français']],
             ['english', 'eng-GB', ['eng-GB' => 'english']],
             ['norsk', 'nor-NO', ['nor-NO' => 'norsk']],