Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-31322: Fixed padding for tabs #1209

Merged
merged 1 commit into from
Jan 27, 2020
Merged

EZP-31322: Fixed padding for tabs #1209

merged 1 commit into from
Jan 27, 2020

Conversation

lucasOsti
Copy link
Contributor

Question Answer
Tickets https://jira.ez.no/browse/EZP-31322
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

bogusez
bogusez suggested changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@bogusez bogusez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this task on native resolutions (800x600, 1024x768, 1280x1024 etc.) and page behaviour propertly until 1280x1024 resolution. Every higher resolution starting from 1600x1280 behaviour incorrectly.

@lucasOsti
Copy link
Contributor Author

I have tested this task on native resolutions (800x600, 1024x768, 1280x1024 etc.) and page behaviour propertly until 1280x1024 resolution. Every higher resolution starting from 1600x1280 behaviour incorrectly.

As we spoke, retesting needed without code changes :)

@bogusez
Copy link
Contributor

bogusez commented Jan 27, 2020

I have tested this task on native resolutions (800x600, 1024x768, 1280x1024 etc.) and page behaviour propertly until 1280x1024 resolution. Every higher resolution starting from 1600x1280 behaviour incorrectly.

As we spoke, retesting needed without code changes :)

Yes, my bad. Sorry

@lserwatka lserwatka merged commit 45a5fee into ezsystems:master Jan 27, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees
No one assigned
Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucasOsti @bogusez @GrabowskiM @dew326 @lserwatka