[Behat] Changed selecting multiple items to be more bullet-proof #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnocon
changed the title
mnocon
requested review from
bogusez,
katarzynazawada,
micszo and
tomaszszopinski
mnocon
force-pushed
the
fix-udw-issues
branch
from
ca87baa to
9d9a014
Compare
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reviewing please ignore Travis changes.Example failures this PR tries to fix:
https://travis-ci.org/ezsystems/ezplatform-admin-ui/jobs/644285679?utm_medium=notification&utm_source=slack
https://travis-ci.com/ezsystems/ezplatform-page-builder/jobs/282689221?utm_medium=notification&utm_source=slack
https://travis-ci.com/ezsystems/ezplatform-page-builder/jobs/282125374?utm_medium=notification&utm_source=slack
Description
Looks like we have a problem in UDW when we try to select multiple items at the same time - the UDW branches loaded for previous item interfere when selecting the next one. This PR tries to detect this scenario and handle it in a better way.
I've run this scenario on 40 jobs, all of them were green:
https://travis-ci.org/ezsystems/ezplatform-admin-ui/builds/644539348?utm_source=github_status&utm_medium=notification
https://travis-ci.org/ezsystems/ezplatform-admin-ui/builds/644595500?utm_source=github_status&utm_medium=notification
So there is a chance this helps 😉
Checklist:
$ composer fix-cs)TO DO BEFORE MERGING: