Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZP-31405 - fix embed image link removal #1255

Merged
merged 2 commits into from
Jun 2, 2020
Merged

EZP-31405 - fix embed image link removal #1255

merged 2 commits into from
Jun 2, 2020

Conversation

ITernovtsii
Copy link
Contributor

@ITernovtsii ITernovtsii commented Feb 21, 2020

Question Answer
Tickets EZP-31405
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Make sure not removed by CKEditor HTML parser when <ezlink> located above <ezconfig> element inside embed image element (which is the case if content migrated from legacy).

not reproducible with eZPlatform v3

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ITernovtsii ITernovtsii requested a review from dew326 February 21, 2020 13:50
Copy link
Member

@dew326 dew326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small coding standard

Co-Authored-By: Dariusz Szut <dew326@gmail.com>
@ITernovtsii ITernovtsii requested a review from dew326 May 29, 2020 11:06
@dew326 dew326 requested a review from GrabowskiM May 29, 2020 11:14
@lserwatka lserwatka merged commit 7190916 into ezsystems:1.5 Jun 2, 2020
@lserwatka
Copy link
Member

@dew326 could you merge it up?

@dew326
Copy link
Member

dew326 commented Jun 2, 2020

Done

# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

5 participants