Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZP-31459: [UDW] Allowed Content Types are not respected in object relation field #1307

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

konradoboza
Copy link
Member

Question Answer
Tickets EZP-31459
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

If allowed_content_types key is not specified in the configuration (null value) the whole subscriber stops at this point even though the next condition provides proper handling for that case.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@konradoboza
Copy link
Member Author

In case if both config and context set during creating/editing CT are empty the resulting value is [] which means none CTs available in the relation list. It needs to be set as null instead.

@konradoboza konradoboza requested review from ViniTou and adamwojs March 26, 2020 13:10
@konradoboza konradoboza requested a review from Nattfarinn March 31, 2020 14:07
@konradoboza konradoboza requested a review from lserwatka April 8, 2020 13:59
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 3 OS and eZPlatform 3.0.1 with patch.

@lserwatka lserwatka merged commit c15df5d into master Apr 14, 2020
@lserwatka lserwatka deleted the EZP-31459-udw_allowed_cts branch April 14, 2020 14:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

6 participants