Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Behat] Changed to comparing keywords ignoring their order #1316

Merged
merged 1 commit into from
Mar 27, 2020
Merged

[Behat] Changed to comparing keywords ignoring their order #1316

merged 1 commit into from
Mar 27, 2020

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Mar 27, 2020 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-31471
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed?
License GPL-2.0

https://jira.ez.no/browse/EZP-31471 changed how the keyword fieldtype behaves, adjusting for changes done there:

  • the expected items are not compared as a string, but instead are parsed into separate keywords and are compared as collections (without taking the order into account).

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mnocon mnocon changed the title [WIP] [Behat] Adjusted expected order of items in keyword field [Behat] Adjusted expected order of items in keyword field Mar 27, 2020
@mnocon mnocon changed the title [Behat] Adjusted expected order of items in keyword field [Behat] Changed to comparing keywords ignoring their order Mar 27, 2020
@micszo micszo merged commit c7fc50d into ezsystems:master Mar 27, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@micszo micszo micszo approved these changes

@mikolajkaraczyn mikolajkaraczyn Awaiting requested review from mikolajkaraczyn

Assignees
No one assigned
Labels
Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mnocon @micszo @katarzynazawada @tomaszszopinski @bogusez