EZP-31539: Link Validation error in Richtext Editor #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dew326
approved these changes
Apr 8, 2020
|
Added handling for links like |
GrabowskiM
approved these changes
Apr 9, 2020
bogusez
approved these changes
Apr 10, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still unhandled cases when pasting links in RTE (
mailto,skype,calltoetc). Instead of adding more of restricted keywords (which could also be error-prone if the keyword is a present outside schema), I changed regexp to verify whether any schema was present before changing the actual URL. It should also work properly when someone uses some custom link schema, likemyschema://.Checklist:
$ composer fix-cs)