Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZP-31545: Filtered empty idString #1340

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Apr 8, 2020

Question Answer
Tickets https://jira.ez.no/browse/EZP-31545
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

As it was reported as "pgsql only", it turned out it is just because

SELECT COUNT(*) FROM ezcontentobject_tree t INNER JOIN ezcontentobject c ON t.contentobject_id = c.id INNER JOIN ezcontentobject_version v ON c.id = v.contentobject_id WHERE ((1 = 1) AND (t.node_id IN (?))) AND (c.status = ?) AND (v.status = ?) AND (t.depth <> ?) AND ((c.language_mask & ?) > ?)' with params ["NaN", 1, 1, 0, 3, 0]

is valid query for mysql.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ViniTou ViniTou force-pushed the ezp-31545-NaN-as-parameter-in-query branch from 24ab701 to bba4bcd Compare April 8, 2020 09:38
@micszo micszo self-assigned this Apr 8, 2020
micszo
micszo previously requested changes Apr 8, 2020
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is incomplete.

Steps:

  1. Create new policy and select limitation while creating it. [OK]
  2. Create new policy without a limitation.
  3. Edit that policy and select limitation. [NOK]

@micszo micszo dismissed their stale review April 8, 2020 13:23

Bcoz Chrome :|

@ViniTou ViniTou requested a review from micszo April 8, 2020 13:25
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on master with pgsql and mysql.

@micszo micszo removed their assignment Apr 8, 2020
@lserwatka lserwatka merged commit 9817bdf into master Apr 8, 2020
@lserwatka lserwatka deleted the ezp-31545-NaN-as-parameter-in-query branch April 8, 2020 13:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

5 participants