Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-29475: Changes for UDW title #1346

Merged
merged 3 commits into from
Apr 17, 2020
Merged

EZP-29475: Changes for UDW title #1346

merged 3 commits into from
Apr 17, 2020

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented Apr 14, 2020 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-29475
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@GrabowskiM GrabowskiM requested review from dew326 and lucasOsti April 14, 2020 10:51
@dew326 dew326 requested a review from DominikaK April 14, 2020 10:55
DominikaK
DominikaK approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@DominikaK DominikaK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for strings

@GrabowskiM GrabowskiM requested a review from dew326 April 14, 2020 11:04
dew326
dew326 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@dew326 dew326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prepare PR in ezplatform-richtext for 3.0.

@GrabowskiM GrabowskiM force-pushed the EZP-29475-changes-for-udw-title branch from 846aae2 to 06e7d3e Compare April 15, 2020 11:23
@lserwatka lserwatka merged commit 0ab4926 into ezsystems:1.5 Apr 17, 2020
@lserwatka
Copy link
Member

You can merge it up to 2.0 and master

@GrabowskiM GrabowskiM mentioned this pull request Apr 17, 2020
Merged
4 tasks
@GrabowskiM
Copy link
Contributor Author

Merge up done

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@DominikaK DominikaK DominikaK approved these changes

@dew326 dew326 dew326 approved these changes

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GrabowskiM @lserwatka @dew326 @DominikaK @lucasOsti @bogusez