EZP-31576: When in COTF make UDW & consecutive COTF views take the full view #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
approved these changes
May 19, 2020
|
Here I'm not sure if we should hide the cancel and save button when the user enters the create form in the inside UDW or we just do it when a user opens the second UDW inside, I think the latter solution is more intuitive and in line with Form builder for example. |
|
@dew326 I agree with you. I think it makes sense to hide the buttons when user opens a second UDW. It should also be the case if the user opens a third one and so on. |
|
I agree @dew326, second option's transition is consistent with the existing case in Form Builder. I also agree with @SylvainGuittard's proposal. |
GrabowskiM
force-pushed
the
EZP-31576-hide-parent-footer-in-cotf
branch
from
49c73f9 to
82baea3
Compare
dew326
approved these changes
Jul 21, 2020
GrabowskiM
force-pushed
the
EZP-31576-hide-parent-footer-in-cotf
branch
from
74530e5 to
bb19340
Compare
dew326
approved these changes
Jul 21, 2020
GrabowskiM
force-pushed
the
EZP-31576-hide-parent-footer-in-cotf
branch
from
73418f0 to
07a9b69
Compare
tomaszszopinski
approved these changes
Jul 22, 2020
|
You can merge it up. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)