Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZEE-3167: Added generation of Site Access name for Sites #1405

Merged
merged 4 commits into from
Jun 23, 2020
Merged

EZEE-3167: Added generation of Site Access name for Sites #1405

merged 4 commits into from
Jun 23, 2020

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Jun 18, 2020 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZEE-3167
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
Related PR https://github.com/ezsystems/ezplatform-site-factory/pull/70
License GPL-2.0

List of the Site Accesses should come from siteAccessService. Site Factory should have the possibility to modify the Site Access name.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mikadamczyk mikadamczyk self-assigned this Jun 18, 2020
@mikadamczyk mikadamczyk changed the base branch from master to 2.0 June 18, 2020 13:01
@mikadamczyk mikadamczyk force-pushed the EZEE-3167-preview branch 2 times, most recently from e2d14d0 to 901eb93 Compare June 22, 2020 09:01
@mikadamczyk mikadamczyk changed the title EZEE-3189: Added generation of Site Access name for Sites EZEE-3167: Added generation of Site Access name for Sites Jun 22, 2020
@micszo micszo self-assigned this Jun 22, 2020
@micszo micszo removed their assignment Jun 22, 2020
@lserwatka lserwatka merged commit fd0858c into 2.0 Jun 23, 2020
@lserwatka lserwatka deleted the EZEE-3167-preview branch June 23, 2020 07:51
@lserwatka
Copy link
Member

You can merge it up.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@micszo micszo micszo approved these changes

@adamwojs adamwojs adamwojs approved these changes

@michal-myszka michal-myszka Awaiting requested review from michal-myszka

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@mikadamczyk mikadamczyk

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikadamczyk @lserwatka @adamwojs @micszo @ViniTou