EZP-31767: Use version contributor name on dashboard #1437
Conversation
| * | ||
| * @return \eZ\Publish\API\Repository\Values\User\User|null | ||
| */ | ||
| protected function getContributor(ContentInfo $contentInfo): ?User | ||
| protected function getVersionContributor(VersionInfo $versionInfo): ?User |
There was a problem hiding this comment.
Not sure if renaming protected function in abstract class is the safest way to do, it should be internal but maybe someone else have opinion on that too.
There was a problem hiding this comment.
May I create a separate getVersionContributor method, and keep getContributor as is? And, mark getContributor with @deprecated?
| $userExists = (new UserExists($this->userService))->isSatisfiedBy($contentInfo->ownerId); | ||
|
|
||
| if (false === $userExists) { | ||
| try { |
There was a problem hiding this comment.
Any reason why you did not reuse Specification just with different ID provided?
There was a problem hiding this comment.
@ViniTou This method called for each row, so this will save us a few userService->loadUser() calls, which will make the dashboard page a bit faster.
IMHO, UserExists->isSatisfiedBy is overcomplicating the simple thing, user service is doing this job quite well already. Probably, it is the reason why it's not used commonly through the code.
Let me know if these few extra calls are not a big deal and I'll change it to use UserExists.
Thanks.
There was a problem hiding this comment.
True, I didnt notice the last removed call, fine with me then.
adamwojs
changed the title
|
Thank you for contribution @ITernovtsiy! |
Currently, on content view page, we have displayed name of user who last edited the content.
But creator name displayed as a contributor on the dashboard (In common content block)
I would expect to see name of user who last edited the content.
Checklist:
$ composer fix-cs)