-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
EZP-31875: Added request matcher to recognize REST requests executed in AdminUI context #1488
Conversation
I suggest you change the commit and PR's descriptions to match what that specific PR actually does (e.g. add a REST + Admin request matcher). It can easily get confusing in changelogs. The code itself should probably not refer to JWT either. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 but we are missing unit tests coverage.
The code itself should probably not refer to JWT either.
Agree with @bdunogier, matcher could be used in other scenarios as well 😉
@kmadejski we need to add tests as well |
@kmadejski Could you elaborate on that? What does it do? |
|
Ok, +1 once test coverage is present. |
This PR introduces a
RequestMatcher
that is needed for ezsystems/ezplatform-rest#54.I'm happy to change the class name if someone has any better ideas.
Checklist:
$ composer fix-cs
)