EZP-31784: Enable autosave feature for Content on the Fly #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nattfarinn
requested review from
kaff,
adamwojs,
mikadamczyk,
damianz5,
alongosz,
ciastektk,
webhdx,
dew326 and
ViniTou
ciastektk
reviewed
Oct 13, 2020
ciastektk
approved these changes
Oct 13, 2020
adamwojs
reviewed
Oct 13, 2020
Steveb-p
reviewed
Oct 13, 2020
Nattfarinn
force-pushed
the
ezp-31784-cotf
branch
from
183ffaf to
6f9d769
Compare
Nattfarinn
force-pushed
the
ezp-31784-cotf
branch
from
6f9d769 to
36fc5b6
Compare
adamwojs
approved these changes
Oct 13, 2020
alongosz
approved these changes
Oct 13, 2020
mikadamczyk
reviewed
Oct 13, 2020
| $location = $this->locationService->loadLocation($locationId); | ||
|
|
||
| $location = null; | ||
| if (!empty($locationId)) { |
There was a problem hiding this comment.
It is worth to perform more strict check, maybe locationId !== null
There was a problem hiding this comment.
@Nattfarinn please address it as a followup
There was a problem hiding this comment.
Fixed here: #1588
mikadamczyk
approved these changes
Oct 13, 2020
webhdx
approved these changes
Oct 13, 2020
adamwojs
pushed a commit
to adamwojs/ezplatform-admin-ui
that referenced
this pull request
Oct 21, 2020
adamwojs
pushed a commit
that referenced
this pull request
Oct 22, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Autosave feature for Content on the Fly.
Checklist:
$ composer fix-cs)