Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZP-32008: Redesign pagination #1581

Merged

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Oct 13, 2020

Question Answer
Tickets https://jira.ez.no/browse/EZP-32008
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? no
Doc needed? no
License GPL-2.0

Screenshot from 2020-10-14 10-17-45

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lucasOsti lucasOsti marked this pull request as draft October 13, 2020 12:22
@lucasOsti lucasOsti marked this pull request as ready for review October 14, 2020 08:17
@@ -1,10 +1,11 @@
<div class="row justify-content-center align-items-center ez-pagination__spacing">
<span class="ez-pagination__text">
<div class="ez-pagination">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have to templates with pagination but used in only the one in ui?

<div class="ez-pagination__navigation">
{{ pagerfanta(pager, 'ez', paginaton_params|default({})) }}
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing empty line

@lucasOsti lucasOsti requested a review from dew326 October 14, 2020 08:56
@dew326 dew326 merged commit c020b1d into ezsystems:master Oct 14, 2020
adamwojs pushed a commit to adamwojs/ezplatform-admin-ui that referenced this pull request Oct 21, 2020
adamwojs pushed a commit that referenced this pull request Oct 22, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants