Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-28322: No space between validation message and field label #162

Merged
merged 1 commit into from
Dec 13, 2017
Merged

EZP-28322: No space between validation message and field label #162

merged 1 commit into from
Dec 13, 2017

Conversation

sunpietro
Copy link
Contributor

Question Answer
Tickets https://jira.ez.no/browse/EZP-28389
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes/no
Doc needed? yes/no
License GPL-2.0

Additionaly, I've added a visual error state to the alternative text input when it's empty and required.

@sunpietro sunpietro self-assigned this Dec 12, 2017
@barbaragr barbaragr self-assigned this Dec 13, 2017
dew326
dew326 requested changes Dec 13, 2017
View reviewed changes
src/bundle/Resources/public/scss/fieldType/_ezimage.scss Outdated
}

.ez-data-source__input {
background: #fceaec;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing variable

@sunpietro sunpietro force-pushed the ezp-28322-add-spacing-between-label-and-error-message branch from 106505a to 9e880bf Compare December 13, 2017 07:22
@sunpietro
Copy link
Contributor Author

ping @dew326

@barbaragr
Copy link

  1. Image:
    a) Go to Create and choose content type with required ezimage
    b) click Publish - there is a validation alert on image
    c) upload an image - message is shown for alt text like this (glued to :, black):
    screen shot 2017-12-13 at 09 17 50
    d) click Publish once again - now validation message is shaped up
    screen shot 2017-12-13 at 09 18 01

  2. Author - there is still no space for a Name and E-mail
    screen shot 2017-12-13 at 09 24 23

  3. URL - there is still no space
    screen shot 2017-12-13 at 09 24 32

  4. Selection and User- I can't test it, because validation alert isn't shown at all

barbaragr
barbaragr requested changes Dec 13, 2017
View reviewed changes
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put some issues in a comment

@barbaragr barbaragr removed their assignment Dec 13, 2017
@sunpietro sunpietro force-pushed the ezp-28322-add-spacing-between-label-and-error-message branch 2 times, most recently from 5690d11 to e67ef6a Compare December 13, 2017 08:51
@sunpietro sunpietro force-pushed the ezp-28322-add-spacing-between-label-and-error-message branch from e67ef6a to 716b267 Compare December 13, 2017 10:02
@lserwatka lserwatka merged commit 5a07a19 into master Dec 13, 2017
@sunpietro sunpietro deleted the ezp-28322-add-spacing-between-label-and-error-message branch December 13, 2017 10:09
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
@dew326
IBX-1812: Added labels in table buttons (#162)
043d331
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@barbaragr barbaragr barbaragr approved these changes

@dew326 dew326 dew326 approved these changes

@lserwatka lserwatka Awaiting requested review from lserwatka

Assignees

@sunpietro sunpietro

Labels
Bug QA approved Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunpietro @barbaragr @dew326 @lserwatka