Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-664: changed desc for pagination.viewing trans #1787

Merged
merged 1 commit into from
Jul 1, 2021
Merged

IBX-664: changed desc for pagination.viewing trans #1787

merged 1 commit into from
Jul 1, 2021

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
Tickets IBX-664
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@dew326
Copy link
Member

dew326 commented Jun 29, 2021

I think 3.3 is also affected, this should be merged to 2.3 branch.

@mateuszdebinski mateuszdebinski changed the base branch from master to 2.3 June 29, 2021 07:49
@mateuszdebinski
Copy link
Contributor Author

I think 3.3 is also affected, this should be merged to 2.3 branch.

Yes, my mistake, I forgot to change the branch to correct, now changes to 2.3

@mateuszdebinski mateuszdebinski force-pushed the IBX-664-problem-with-desc-trans branch from f0b6a50 to 8944133 Compare June 30, 2021 10:59
@bogusez bogusez self-assigned this Jul 1, 2021
@bogusez
Copy link
Contributor

bogusez commented Jul 1, 2021

Screenshot 2021-07-01 at 08 35 58

As discussed with Mateusz, it will be fixed in different task / pull request.

@mateuszdebinski
Copy link
Contributor Author

Screenshot 2021-07-01 at 08 35 58

As discussed with Mateusz, it will be fixed in different task / pull request.

This problem looks like an older fixed issue: https://issues.ibexa.co/browse/EZP-29674

@lserwatka lserwatka merged commit 8e8173d into 2.3 Jul 1, 2021
@lserwatka lserwatka deleted the IBX-664-problem-with-desc-trans branch July 1, 2021 07:33
@lserwatka
Copy link
Member

You can merge it up.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@konradoboza konradoboza konradoboza approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

Assignees

@bogusez bogusez

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mateuszdebinski @dew326 @bogusez @lserwatka @tischsoic @konradoboza