Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-808: As an Editor, I want to be able to reset starting location for ezobjectrelation FieldType #1880

Merged
merged 4 commits into from
Sep 6, 2021
Merged

IBX-808: As an Editor, I want to be able to reset starting location for ezobjectrelation FieldType #1880

merged 4 commits into from
Sep 6, 2021

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented Sep 1, 2021 •
edited
Loading

Question Answer
Tickets IBX-808
Bugfix? no
Improvement? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Excerpt from JIRA:

Currently, after selecting "Starting Location" in ezobjectrelation settings, there is no way to reset it. This might get problematic when, for some reason, the initial content is not visible in UDW due to tree_root parameter usage or associated user permissions.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@konradoboza konradoboza self-assigned this Sep 1, 2021
@konradoboza konradoboza requested a review from dew326 September 1, 2021 11:45
@konradoboza konradoboza requested a review from dew326 September 1, 2021 11:50
@konradoboza konradoboza requested a review from dew326 September 1, 2021 11:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza removed their assignment Sep 2, 2021
kacper-wieczorek-ibexa
kacper-wieczorek-ibexa approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qa -approved - Function 'Reset start location' at 'ezobjectrelation' is added and works properly for v2.5.23.

@mikadamczyk mikadamczyk merged commit 42445c0 into 1.5 Sep 6, 2021
@mikadamczyk mikadamczyk deleted the ibx-808-resetting-starting-location branch September 6, 2021 13:44
@mikadamczyk
Copy link
Contributor

Could you merge it up @konradoboza ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa kacper-wieczorek-ibexa approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees
No one assigned
Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@konradoboza @mikadamczyk @GrabowskiM @tischsoic @dew326 @lucasOsti @kacper-wieczorek-ibexa