Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-1356: Backported fix for TranslationChoiceLoader #1996

Merged
merged 2 commits into from
Nov 9, 2021
Merged

IBX-1356: Backported fix for TranslationChoiceLoader #1996

merged 2 commits into from
Nov 9, 2021

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Nov 3, 2021 •
edited
Loading

Question Answer
Tickets IBX-1356
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Based on: #1885

Related ezplatform-page-builder PR: https://github.com/ezsystems/ezplatform-page-builder/pull/890

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 self-assigned this Nov 3, 2021
@barw4 barw4 requested a review from a team November 3, 2021 14:35
@mikadamczyk mikadamczyk requested review from ViniTou, Steveb-p, adamwojs and a team November 4, 2021 07:56
@piotrbisaga piotrbisaga self-assigned this Nov 8, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@piotrbisaga
Copy link
Contributor

piotrbisaga commented Nov 9, 2021 •
edited
Loading

QA approved.
Checked on eZ ee 2.5 on Chrome & Firefox.

@piotrbisaga piotrbisaga removed their assignment Nov 9, 2021
@ViniTou ViniTou merged commit 35ce913 into 1.5 Nov 9, 2021
@ViniTou ViniTou deleted the ibx-1356-backport-translation-choice-loader-fix branch November 9, 2021 10:14
@barw4 barw4 mentioned this pull request Nov 9, 2021
Merged
@barw4
Copy link
Member Author

barw4 commented Nov 9, 2021

Merged into:
2.3: 359299a
master: 8d3c869
ibexa/admin-ui/main: ibexa/admin-ui#49

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@adamwojs adamwojs adamwojs approved these changes

@ViniTou ViniTou Awaiting requested review from ViniTou

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

Assignees

@barw4 barw4

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barw4 @piotrbisaga @adamwojs @mikadamczyk @ViniTou