Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-1604: Fixed deprecation warning thrown by PHP8 #2019

Merged
merged 1 commit into from
Dec 6, 2021
Merged

IBX-1604: Fixed deprecation warning thrown by PHP8 #2019

merged 1 commit into from
Dec 6, 2021

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented Dec 2, 2021 •
edited
Loading

Question Answer
Tickets IBX-1604
Bug fix? yes
New feature? no
BC breaks? possibly
Tests pass? yes
Doc needed? no
License GPL-2.0 
Deprecated: Optional parameter $siteAccessGroups declared before required parameter defaultTargetPath is implicitly treated as a required parameter in
vendor/ezsystems/ezplatform-admin-ui/src/lib/Security/Authentication/RedirectToDashboardAuthenticationSuccessHandler.php

Not sure about potential BC break, but this approach seems to be more defensive than reordering constructor parameters.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@konradoboza konradoboza added the Bug label Dec 2, 2021
@konradoboza konradoboza self-assigned this Dec 2, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza marked this pull request as ready for review December 2, 2021 13:36
@konradoboza konradoboza requested a review from a team December 2, 2021 13:36
@konradoboza konradoboza requested a review from a team December 2, 2021 13:38
@konradoboza konradoboza removed their assignment Dec 2, 2021
@micszo micszo self-assigned this Dec 3, 2021
micszo
micszo approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with ezsystems/ezplatform-kernel#264.

@adamwojs adamwojs merged commit c44920c into 2.3 Dec 6, 2021
@adamwojs adamwojs deleted the ibx-1604-deprecation-warnings branch December 6, 2021 14:47
@micszo micszo removed their assignment Dec 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@micszo micszo micszo approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees
No one assigned
Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@konradoboza @Steveb-p @micszo @ViniTou @adamwojs