Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Tests] Fixed SiteAccessLimitationMapperTest generate mock #2087

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Feb 8, 2023

Question Answer
JIRA issue n/a
Type bug
Target Ibexa version v3.3+
BC breaks no

SiteAccessKeyGeneratorInterface::generate(string) returns string, not SiteAccessKeyGenerator as previously mocked.
This results in a silent error:

Method generate may not return value of type EzSystems\EzPlatformAdminUi\Siteaccess\SiteAccessKeyGenerator, its return declaration is ": string"

Noticed while working on the other PR. Worth fixing to avoid spending time investigating if the failure is related or not to the current changes.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review

@konradoboza konradoboza requested a review from a team February 8, 2023 12:05
Co-authored-by: Konrad Oboza <konrad.oboza@ez.no>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikadamczyk mikadamczyk merged commit 635e494 into 2.3 Feb 8, 2023
@mikadamczyk mikadamczyk deleted the fix-sa-limitation-mapper-test branch February 8, 2023 14:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

8 participants