Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

IBX-6451: Calculating the size of the dropdown element has been changed #2110

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
Tickets IBX-6451
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

as itemsContainerTop may be too large relative to the remaining height of the bottom element at times. Therefore, a calculation was added on how much is left from the top of the modal to a given element. To check whether this value is greater or smaller than itemsContainerTop, also I did not subtract DROPDOWN_MARGIN from this value, because the margin is the size of the element

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

…e remaining height to the bottom of the element
@mateuszdebinski mateuszdebinski changed the title IBX-6451: Added verifications of what smaller itemsContainerTop or the remaining height to the bottom of the element IBX-6451: Calculating the size of the dropdown element has been changed Sep 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs merged commit 30c6715 into 2.3 Sep 1, 2023
@adamwojs adamwojs deleted the IBX-6451_language_list_scroll branch September 1, 2023 12:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

5 participants