Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-7046: Fixed Dashboard "My Content" & "My Media" edit buttons #2114

Merged
merged 2 commits into from
Jan 25, 2024
Merged

IBX-7046: Fixed Dashboard "My Content" & "My Media" edit buttons #2114

merged 2 commits into from
Jan 25, 2024

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jan 16, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7046
Type bug
Target Ibexa version v3.3+
BC breaks no

Version Info containing translation data needs to be always mapped for Content Edit [translation] button to work properly.

Both "My Content" and "My Media" were having the same issue.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage (missing Behat?).
  • Checked that target branch is set correctly.
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@webhdx webhdx requested a review from a team January 17, 2024 11:03
@ciastektk ciastektk requested a review from a team January 17, 2024 11:04
@micszo micszo self-assigned this Jan 24, 2024
This was referenced Jan 25, 2024
Closed
Closed
micszo
micszo approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa DXP 3.3.37-dev.

@micszo micszo removed their assignment Jan 25, 2024
@ViniTou ViniTou merged commit b0db6f5 into 2.3 Jan 25, 2024
15 checks passed
@ViniTou ViniTou deleted the ibx-7046-fix-editing-my-content-my-media branch January 25, 2024 12:11
@alongosz alongosz mentioned this pull request Jan 25, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@micszo micszo micszo approved these changes

@webhdx webhdx webhdx approved these changes

@ciastektk ciastektk ciastektk approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@barw4 barw4 Awaiting requested review from barw4

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels
Bug QA approved Ready for MERGE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@alongosz @Nattfarinn @ciastektk @webhdx @micszo @ViniTou @konradoboza @mikadamczyk