Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

IBX-7954: Show error message on empty image asset #2116

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Mar 18, 2024

Question Answer
Tickets IBX-7954
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

In case a chosen related asset has no image instead of JS console error we should show a message.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 requested a review from GrabowskiM March 18, 2024 14:15
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dew326 dew326 merged commit 2ffae96 into 2.3 Mar 26, 2024
13 checks passed
@dew326 dew326 deleted the ibx-7954-message-on-empty-image-asset-data branch March 26, 2024 12:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

10 participants